Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug with sound tags #141

Closed
wants to merge 1 commit into from
Closed

Conversation

ilmar85
Copy link

@ilmar85 ilmar85 commented May 19, 2020

Javasound minim bug fixed #138
Renamed mainclass #135

@Stephcraft
Copy link
Owner

How did you fix the mp3s?

@ilmar85
Copy link
Author

ilmar85 commented May 20, 2020

How did you fix the mp3s?

i removed tags from mp3 :)

minim lib does not support the tag tts

@micycle1
Copy link
Collaborator

I'm not in favor of refactoring SideScroller (in its present form) to Main.

Better would be to split out some code from SideScroller (such as PApplet.main(SideScroller.class, args);) into a new class called Main, retaining Processing code in SideScroller -- perhaps this could be renamed to something like Game.

@ilmar85
Copy link
Author

ilmar85 commented May 20, 2020

I'm not in favor of refactoring SideScroller (in its present form) to Main.

Better would be to split out some code from SideScroller (such as PApplet.main(SideScroller.class, args);) into a new class called Main, retaining Processing code in SideScroller -- perhaps this could be renamed to something like Game.

i am agree with you
I don't quite understand the need to rename the class. But I was acting within issue #133

@ilmar85 ilmar85 closed this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix minim audio library errors printed to console
3 participants