Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unpin urllib3 #408

Merged
merged 1 commit into from
Mar 26, 2024
Merged

chore: unpin urllib3 #408

merged 1 commit into from
Mar 26, 2024

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Mar 25, 2024 •
edited
Loading

Related issue

closes FL-1514
CI ✅

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@ThibaultFy
chore: unpin urlib 2
0ce8c2b 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Mar 25, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Awesome sauce!

@ThibaultFy ThibaultFy changed the title chore: unpin urlib 2 chore: unpin urllib3 2 Mar 25, 2024
@linear Linear
Copy link

linear bot commented Mar 25, 2024

FL-1514 Investigate why urllib3<2 in Substra sdk

@ThibaultFy ThibaultFy marked this pull request as ready for review March 25, 2024 17:21
@ThibaultFy ThibaultFy requested a review from a team as a code owner March 25, 2024 17:21
@ThibaultFy ThibaultFy changed the title chore: unpin urllib3 2 chore: unpin urllib3 Mar 25, 2024
@ThibaultFy ThibaultFy merged commit 88df660 into main Mar 26, 2024
5 checks passed
@ThibaultFy ThibaultFy deleted the unpin-urlib branch March 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @SdgJlbl