Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to activate gitlab-manager when gitlab-integration is installed #13

Open
1 task
mikey- opened this issue Apr 11, 2023 · 0 comments · May be fixed by #14
Open
1 task

Unable to activate gitlab-manager when gitlab-integration is installed #13

mikey- opened this issue Apr 11, 2023 · 0 comments · May be fixed by #14

Comments

@mikey-
Copy link

mikey- commented Apr 11, 2023

Prerequisites

Description

When both gitlab-manager and gitlab-integration are installed, there is an error activating gitlab-manager, as it tries to create elements which already exist (because gitlab-integration created them).

Steps to Reproduce

  1. install gitlab-manager: ppm install gitlab-manager
  2. install gitlab-integration: ppm install gitlab-integration
  3. open pulsar

Expected behavior:

Both packages should load without error

Actual behavior:

gitlab integration loads, creates elements on the status bar, etc - gitlab-manager tries to load and create the same elements, which fails and causes the error I'm reporting

Versions

Atom: 1.103.0 arm64
Electron: 12.2.3
OS: macOS 13.2.1
Thrown From: gitlab-manager package 0.2.2

Stack Trace

Failed to activate the gitlab-manager package

At A status-bar-gitlab type is already registered

Error: A status-bar-gitlab type is already registered
    at throwTypeError (/app.asar/node_modules/document-register-element/build/document-register-element.node.js:1264:11)
    at registerElement (/app.asar/node_modules/document-register-element/build/document-register-element.node.js:1022:9)
    at HTMLDocument.document.registerElement (/app.asar/static/index.js:103:14)
    at /packages/gitlab-manager/lib/status-bar-view.coffee:201:27)
    at /packages/gitlab-manager/lib/status-bar-view.coffee:1:1)
    at /packages/gitlab-manager/lib/status-bar-view.coffee:1:1)
    at Module._compile (/app.asar/src/native-compile-cache.js:120:30)
    at /app.asar/src/compile-cache.js:252:23)
    at Module.load (internal/modules/cjs/loader.js:935:32)
    at Module._load (internal/modules/cjs/loader.js:776:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Function.o._load (electron/js2c/renderer_init.js:33:379)
    at Module.require (internal/modules/cjs/loader.js:959:19)
    at require (/app.asar/src/native-compile-cache.js:67:27)
    at /packages/gitlab-manager/lib/gitlab-manager.coffee:4:17)
    at /packages/gitlab-manager/lib/gitlab-manager.coffee:1:1)
    at /packages/gitlab-manager/lib/gitlab-manager.coffee:1:1)
    at Module._compile (/app.asar/src/native-compile-cache.js:120:30)
    at /app.asar/src/compile-cache.js:252:23)
    at Module.load (internal/modules/cjs/loader.js:935:32)
    at Module._load (internal/modules/cjs/loader.js:776:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Function.o._load (electron/js2c/renderer_init.js:33:379)
    at Module.require (internal/modules/cjs/loader.js:959:19)
    at require (/app.asar/src/native-compile-cache.js:67:27)
    at requireModule (/app.asar/src/module-utils.js:3:17)
    at Package.requireMainModule (/app.asar/src/package.js:909:27)
    at Package.activateNow (/app.asar/src/package.js:232:34)
    at /app.asar/src/package.js:211:27
    at Package.measure (/app.asar/src/package.js:82:19)

Commands

     -9:38.9.0 core:paste (input.hidden-input)
     -9:37.3.0 core:save (input.hidden-input)
     -1:36.1.0 application:add-project-folder (div.tool-panel.tree-view)
     -1:19.4.0 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)
     -1:14.5.0 project-find:show-in-current-directory (span.name.icon.icon-repo)
     -1:13.1.0 core:paste (input.hidden-input)
     -1:12.6.0 core:confirm (input.hidden-input)
     -1:11 core:backspace (input.hidden-input)
     -1:10.4.0 core:confirm (input.hidden-input)
     -1:04.3.0 core:move-right (input.hidden-input)
     -1:04.0 core:move-left (input.hidden-input)
  2x -0:58 core:confirm (input.hidden-input)
     -0:19.7.0 intentions:highlight (input.hidden-input)
     -0:19.6.0 core:save (input.hidden-input)
     -0:17.7.0 intentions:highlight (input.hidden-input)
     -0:17.6.0 core:save (input.hidden-input)

Non-Core Packages

activate-power-mode 2.7.0 
atom-cfn-lint 0.7.0 
atom-typescript 14.4.0 
busy-signal 2.0.1 
compare-files 0.8.1 
gitlab-integration 0.4.8 
gitlab-manager 0.2.2 
iam-syntax 0.1.5 
intentions 2.1.1 
json-converter 0.2.4 
language-antlr4 0.1.0 
language-yaml-cloudformation 0.3.1 
linter 3.4.0 
linter-markdown 5.2.11 
linter-swagger 0.6.1 
linter-ui-default 3.4.1 
linter-yaml 1.1.3 
markdown-deluxe 1.0.0 
markdown-preview-enhanced-with-litvis 0.34.0 
neon-cursor 1.6.0 
neon-selection 0.3.2 
power-effects 0.5.0 
prettier-atom 0.60.1 
syntax-neonize 3.3.0 
toggle-gitignore 1.0.0

Additional Information

I think it would be sufficient to simply use the name status-bar-gitlab-manager, rather than status-bar-gitlab.
@mikey- mikey- linked a pull request Apr 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use package name as tag-name to avoid clashes mikey-/gitlab-manager
1 participant
@mikey-