Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Extension's current inline edit always prompts a blank line under the header. #3284

Open
Sma1lboy opened this issue Oct 17, 2024 · 2 comments
Assignees

Comments

@Sma1lboy
Copy link
Collaborator

Please describe the feature you want
Every time I try to use inline edit, I find that a blank line appears in the new edited area. This affects the quality of the inline edit in some cases, especially for dense lines of code.

Screen.Recording.2024-10-17.at.01.44.12.mov

Please reply with a 👍 if you want this feature.

@Sma1lboy Sma1lboy added enhancement New feature or request bug-unconfirmed and removed enhancement New feature or request labels Oct 17, 2024
@Sma1lboy
Copy link
Collaborator Author

the generate docs command generated one more \n

here is my debug output:

[inline-ediet] edit.editedText: \\nimport { window, LogOutputChannel } from \"vscode\";\\n

[inline-ediet] edit.originalText: import { window, LogOutputChannel } from \"vscode\";\\n

@Sma1lboy
Copy link
Collaborator Author

Sma1lboy commented Oct 24, 2024

Follow up:

After careful consideration from multiple perspectives, we have decided not to proceed with this change for now. We observed that blank line behavior varies depending on user input commands and default prompts. Our current strategy is to avoid enforcing this through rules or fixing it by diffing original code against generated code. In one scenario, users may consent to LLM inline edits that directly add extra blank lines. There is significant overlap between different cases. Therefore, this issue is currently on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant