This repository has been archived by the owner on Jul 13, 2024. It is now read-only.
Fix Minor Scale #104
Closed
Fix Minor Scale #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's been a while since I looked at the Bosca code, so yep, I'm not sure if this is safe to merge as is, if it might make old saved songs sound different in a new version. But it is a helpful reference, so thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the (natural) Minor Scale (See #103)
I'm actually not sure if this PR can be merged as is (e.g. will this break old files when loaded?), but I think it can be helpful to have this as a reference anyway.