Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving warnings of deprecated react apis #75

Open
smeng9 opened this issue May 26, 2024 · 1 comment
Open

Resolving warnings of deprecated react apis #75

smeng9 opened this issue May 26, 2024 · 1 comment

Comments

@smeng9
Copy link
Contributor

smeng9 commented May 26, 2024

@tnrich

React 19 is going to remove deprecated apis.

It seems there are still cases that we are using old apis like findDOMNode and render

Also do you know why this commit 7b8fcbf#diff-0d834dfe0b1aa1cb2ec5a918b1fee8f2346ca411fcaec907ebe0b1a6d2754b4e is reverted. Is it causing some issues?
@tnrich
Copy link
Collaborator

tnrich commented May 28, 2024

Hi @smeng9 yes that commit was causing quite a few legitimate test failures in cypress so I went ahead and rolled it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnrich @smeng9