Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astro-disable-admin-ui-in-production.mdoc #635

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

barelyhuman
Copy link
Contributor

The API route disable in production code seems to be invalid.

Correcting it by adding a wrapper around the makeHandler in the call. If there's a better API that does this then please let me know and I'll make the needed corrections

Update the code for disabling the API route
@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2023

⚠️ No Changeset found

Latest commit: 81205bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keystar-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2023 1:30pm
keystatic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2023 1:30pm
keystatic-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2023 1:30pm

Copy link
Contributor

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I actually didn't tested with api routes so I'm not surprised it does not work

@emmatown emmatown merged commit 8b1aef4 into Thinkmill:main Sep 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants