Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some things missing that I find useful #13

Open
dominikwilkowski opened this issue Feb 20, 2020 · 6 comments
Open

Some things missing that I find useful #13

dominikwilkowski opened this issue Feb 20, 2020 · 6 comments

Comments

@dominikwilkowski
Copy link

dominikwilkowski commented Feb 20, 2020

Just opinions...

  • .editorconfig
    now please don't shoot me but if we include prettier we should add the editorconfig with the same default settings as the default settings of prettier

  • prettier config and .prettierignore
    leave empty but give people a space where they can put things in

  • npm scripts for prettier and prettier tests
    "format": "prettier --write \"**/*.{js,md,mdx,json}\"",
    "test:format": "prettier --list-different \"**/*.{js,md,mdx,json}\"",

  • cypress integration
    cause I think it's hard and would add a lot of value

  • stuff like yarn start [component]
    "start": "/bin/sh -c 'cd components/${1:-$0} && yarn start'",

Nice to have

  • a create component via a npm script eg yarn create [component] that takes a bunch of files from the .template/ folder and fills in some bits
  • a helpers/ folder with ... helper scripts
  • many packages test scripts
    "dep:test": "manypkg check && preconstruct build || preconstruct dev",
    "dep:fix": "manypkg fix",
@tarang9211
Copy link
Contributor

@dominikwilkowski There's an open PR for cypress integration #11

@dominikwilkowski
Copy link
Author

I saw

@tarang9211
Copy link
Contributor

I saw

Let me know if you feel there's anything missing in the PR. Happy to fill in the gaps!

@Noviny
Copy link
Contributor

Noviny commented Feb 20, 2020

stuff like yarn start [component]

Probably moving away from this as a pattern after Tarang added manypkg run - should document this here though.

@NateRadebaugh
Copy link
Contributor

@dominikwilkowski does prettier expose a .editorconfig? It'd be good if there was some way to keep prettier and .editorconfig in sync without manual intervention

@dominikwilkowski
Copy link
Author

Not that I know of anything, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants