Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TidierData compat issue #124

Open
drizk1 opened this issue Sep 19, 2024 · 5 comments
Open

TidierData compat issue #124

drizk1 opened this issue Sep 19, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@drizk1
Copy link
Member

drizk1 commented Sep 19, 2024

in the toml, the compat for tidierdata is

TidierData = "0.15"

which restricts the tidierdata to an older version

would it be possible to do

TidierData = "0.15-1"

The below created issues when i tried it for .7.8

TidierData = "0.15, 1"
@drizk1 drizk1 added the bug Something isn't working label Sep 19, 2024
@rdboyes
Copy link
Member

rdboyes commented Sep 20, 2024

I removed this change because it isn't accepted by the registry for automerge. We can bump the version to 0.16 though!

@drizk1
Copy link
Member Author

drizk1 commented Sep 20, 2024

that sounds good.

Is it possible to do a range like
".16-1" or the comma which I have been unsuccessful with just to get a little bit of flexibility in?

@rdboyes
Copy link
Member

rdboyes commented Sep 20, 2024

The "-1" part seems to be the issue though. Reading the compat guide, I think "0.16 - 0" may be the right entry. That allows any version prior to 1.0.0

@drizk1
Copy link
Member Author

drizk1 commented Sep 20, 2024

Oh mb it needed decimal like 1.0? But perhaps the 0 works too ?

I read the compat docs but didn't feel so sure when I did it last

@rdboyes
Copy link
Member

rdboyes commented Sep 27, 2024

Changed it to 0.16 via a pull request - now the tests are failing? Not really sure what is restricting tidierdata to 0.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants