Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpatioTemporalDataset.from_dataset does not accept the transform parameter. #30

Open
LucaButera opened this issue Nov 13, 2023 · 1 comment

Comments

@LucaButera
Copy link
Contributor

Issue:
The convenience method SpatioTemporalDataset.from_dataset does not accept any transform parameter, so it either has to be set manually after instantiation or the user must use the standard constructor.

Proposed solution:
Add transform as parameter to from_dataset or move to a kwargs based implementation.

I can implement this based on an agreed upon solution.

@marshka
Copy link
Member

marshka commented Apr 25, 2024

Adding the parameter sounds good to me, I think having only explicit parameters in that method makes all more transparent. More than happy if you could contribute in this regard! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants