Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More decoding options (Base64) #371

Open
3 tasks done
PabloOQ opened this issue Jul 20, 2024 · 0 comments
Open
3 tasks done

More decoding options (Base64) #371

PabloOQ opened this issue Jul 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@PabloOQ
Copy link
Collaborator

PabloOQ commented Jul 20, 2024

Describe a related problem (optional)

So lately google has been using base64 for encoding instead of the percent encoding, here is an example from an issue of ClearURLs.

This has happened to me too, but I didn't keep the URL as I didn't know it was base64, but I remember that the URL Cleaner module totally butchered the URL as it was expecting a query with percent encoding instead of base64, so some rules are affected by this.

Describe your suggested feature

Options to decode on base 64 on multiple modules:

  • URL Cleaner: Tricky, I don't think breaking the spec and adding custom fields ourselves to the rule catalog is an option. The other alternative, would be to have the decodeURIComponent(String text) be smart enough to know which of the different decoding options results in gibberish and which one results in valid URLs.

  • Pattern Checker: Maybe an additional field like decodeMethod in which you choose percent, base64 and any other that might pop in the future.

  • URI Parts: As proposed with URL Cleaner a "smart decoder" would fit best if it has a perfect accuracy, which I don't know if it is possible, as the decoded component might not result in a complete valid URL. The other (bad) alternative is to show both decoded options. This module would benefit a lot of the possibility to see those base64 decoded components because it will make easy to spot when a URL has an encoded component or not like just ID numbers for tracking, a reference to the database of a shortener service or anything that doest not give us any useful information.

Describe alternatives you've considered for your suggested feature

No response

Other details

#10 mentions base64

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@PabloOQ PabloOQ added the enhancement New feature or request label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant