-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apksigner Warning #396
Comments
I'll happily fix that (whenever possible) if I knew how! That is the Github apk, which is built directly from a Github action. I don't use any libraries, and from what I could find, those are automatic files just for metadata, even if they were changed the app should not care, apparently. The only thing I can think of is to use a different signing version (I know there are v1, v2, v3 and even v4?) and I don't really know which one I'm using. |
Thanks for responding. :) I'll see if I can find out.... |
I'm not a dev, but I asked someone who is. He said, "I'm hesitant to give advise since I know almost nothing about his development. So take this w/a grain of salt..." Here it is:
|
From what I could find, this is an issue with the APK signature v1, which doesn't signs files inside the META-INF folder. Signatures v2+ do sign them and have no issue. A google search of "META-INF/com/android/build/gradle/app-metadata.properties" will give several answers to this, like https://stackoverflow.com/questions/77543352/a-file-not-protected-by-signature-unauthorized-modifications-to-this-jar-entry, signalapp/Signal-Android#13270, etc. I'm interested however in which signing version I'm using, as I'm not specifying anything so it's probably the default. Is it v1 only? or v1+v2? Does the output of apksigner says something about this? (I think you need to add the --verbose flag) If I'm only using v1, I should configure it to use both v1 and v2 (at least). If I'm already using v2 it should not be an issue, since devices that support v2 will verify everything, and for older devices that only support v1 I prefer to keep the compatibility instead of making them unable to install the app. Perhaps I could also remove the files as you suggested, but they are automatically built files, and I prefer to avoid touching those. |
LL you're using versions 1 & 2:
|
So, not sure what's going on.
Makes sense. |
Steps to reproduce
I wonder if the dev might be willing to repair this warning from
apksigner
. It would help support consistency with AppVerifier.Expected behavior
No warning.
Actual behavior
warning
URLCheck version
2.1.7 and 3.0
Android version
Android 15
Android Custom/Specific ROM or Device
GrapheneOS
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: