-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Section" block editor UX issues and functionality questions #290
Comments
The extra space is coming from the margin on the last p element not the section itself, but, it's true, the behavior is not consistent when using with the gutter classes. This seems to possibly be an oversight by sitefarm developers. They always use sections in combination with a gutter class, so they probably just never noticed it. I can put in a patch.
It mostly controls button color, but a few other components too. To see it in action:
For left and right padding, gutters should be used. Sitefarm completely removed object boxes from their site, but did not remove the styles. I would advocate using object boxes and spacers where appropriate. IMHO, for reasons I think I ??might?? understand, I think they kind of botched this implementation.
When providing this level of flexibility during content creation, it is impossible to control all class combinations. Some combinations will inevitably be bad, and this is where we have to rely on the judgement of creators.
It goes against spec, but yes, I don't think it will cause too much of an issue down the road.
I can move it to the floating toolbar if you want, but to me, the film colors made more sense grouped in the background image panel since then they appear directly below when the "Apply Brand Color Film" toggle is selected.
I am disinclined to do this - "narrow" and "wide" refer directly to the underlying class name. From a programmer perspective, it will lead to confusion and possible errors. If you want to think of a new label for "gutters" to reflect that the modifier refers to the content width and not the margin size, I can get behind that.
"disabled force contrast" is a modifier for brand classes. If you are using a background image without a a brand color film, it will have no effect. However, if you are using the brand color film, it will generally take precedence over the background image text modifier. |
The built-in gutters on "Section" are far too fat for most of our use cases and provide zero top/bottom padding, so unfortunately I think they will be useless most of the time. If object boxes and spacers ever go away on our site without equivalent solutions, that would suck quite a lot.
To me it would make more sense to have colors managed all in the same spot and only have to select once. For example, if you select "wonder blue" and then add a background image and toggle on "brand color," it should just use the brand color you already selected when it didn't have a background color instead of making that palette selector inactive and making you use a different one from a different sector just to potentially select the same color again. One color palette selector to rule them all. Keeping the opacity sliders where they are in the sidebar is fine though. If that doesn't make sense or isn't doable, let's have an actual zoom chat about it, please.
That's fine with me! Rename "Gutters" to "Content Width." |
I have some questions and UX concerns related to the new "Section" content block --
Functionality questions
Editor UX
As far as I can tell, "disable forced contrast" just forces black text. If this is the case, can you relabel the tooltip to read "force black text" ? "Forced contrast" isn't going to mean anything to a content creator.There are some examples of "Section" set up at the bottom of this Stage page: https://stage.library.ucdavis.edu/june-24-new-content-types/
The text was updated successfully, but these errors were encountered: