Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing to alpaca manager #15

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add testing to alpaca manager #15

wants to merge 13 commits into from

Conversation

DemetreJou
Copy link
Collaborator

Utilize dependency injection pattern to allow testing of functions that require the alpaca manager class

@caixunshiren
Copy link
Member

Hey Demetre I noticed some bugs after you modified the place order (e.g. some api errors and orders not reflected in database). I will try to fix them in these days then merge to main

@DemetreJou
Copy link
Collaborator Author

Hmm, ill look into it as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caixunshiren caixunshiren Awaiting requested review from caixunshiren

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DemetreJou @caixunshiren