-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent deleting left-right bond when unbonding a dongle #2434
Comments
Although, after unpairing, right half goes crazy (reporting nonsense versions, etc). Let me know if you think this may be entirelly fimware fault - in that case, I will invesigate deeper. |
I found the bug. But I am a little bit confused about the fix. Earlier I opened the UltimateHackingKeyboard/agent80#135 PR to allow the host connection deletion even the dongle is not connected to the computer. Now, I added https://github.com/UltimateHackingKeyboard/agent80/pull/135/files#diff-5eccb08619f473487e320189d1770b447b3ac2258c239a2cb14e84cffe272bb5R674 condition. It prevent to treat right half as dongle, but it is an interesting situation because 250ms ago the dongle was connected to the computer. I know uncountable things happen in 250ms
We have a story about in the uhk60 firmware repo UltimateHackingKeyboard/firmware#813 If I don't use wrong unpairing USB commands then it is a firmware bug.
Maybe the I checked the code and almost after all "write" USB command Agent waits until the eeprom is not busy. When recommended wait for the eeprom? |
Shouldn't be needed.
Only when you write flash directly - afaik user config and hardware config. |
@ert78gb it seems like Agent is deleting all bonds on right half in some situations when deleting a dongle host connection. Do you know what these are?
Agent should (almost?) never delete all bonds on right half. There may be situations where it is justified, but from top of my head I can't think of any.
The text was updated successfully, but these errors were encountered: