Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 ECDSA and SignatureCheckerLib will NOT check for non-malleability #524

Open
Vectorized opened this issue Aug 2, 2023 · 2 comments
Open

🚨 ECDSA and SignatureCheckerLib will NOT check for non-malleability #524

Vectorized opened this issue Aug 2, 2023 · 2 comments

Comments

@Vectorized
Copy link
Owner

See: #523

This notice will be kept up for a while.
@BlinkyStitt
Copy link

If we want a function with the malleability check, what do you recommend?

@Vectorized
Copy link
Owner Author

Don't.

If you use a nonce, you will never ever need the malleability check.

The check is just a protection against incorrect usage of signatures.

If you really somehow still need it, use OpenZeppelin.

This was referenced Apr 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BlinkyStitt @Vectorized