Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of objects which can be get trough API #1627

Open
asvishnyakov opened this issue Aug 30, 2019 · 0 comments
Open

Limit the number of objects which can be get trough API #1627

asvishnyakov opened this issue Aug 30, 2019 · 0 comments

Comments

@asvishnyakov
Copy link
Contributor

asvishnyakov commented Aug 30, 2019 •
edited
Loading

Problem:
Currently you may ask hundreds and thousands of objects through "get by ID" or especially search APIs. It will cause large requests to database, high memory usage and problems with cache

Solution:
Return an error if number of objects is large than specified in settings (my proposal is 100 as default value)

Alternative (optional):
Describe this situation in docs, log warning in Application Insights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Woland2k @asvishnyakov @tatarincev @OlegoO @t13ka @yecli @5309