Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Properties using dictionaries don't update when dictionary value is updated or deleted #2688

Open
alynabriscoe opened this issue Aug 25, 2023 · 6 comments

Comments

@alynabriscoe
Copy link

Describe the bug
When you update the value in the dictionary for a given property, that change is not propagated to the items with that property value.

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to an item in the catalog
  2. Click on the properties widget
  3. If you don't already have a property that uses a dictionary, create new property with Value Type "Short Text" and then toggle Dictionary to true. Click Manage Dictionary and add a few values to the list
  4. Back on the item's Property list blade, set the property to one of the dictionary values
  5. Click OK
  6. Click Save on the Physical item details blade
  7. Open the Properties again
  8. Click the edit pencil icon next to the property created
  9. Click Manage Dictionary
  10. EITHER OF THE FOLLOWING
  11. Click on the value you have saved on the item, edit the value text and click Save
  12. OR Delete the value from the dictionary

Expected behavior
If you edited the dictionary value, the property value on the item should reflect the updated value.
If you deleted the value from the dictionary, it should not still be selected in that property.

Screenshots (optional)
If applicable, add screenshots to help explain your problem.

Version info (please complete the following information):

  • Browser version: Google Chrome Version 116.0.5845.97
  • Platform version: 3.31.6.0

Additional context (optional)
Add any other context about the problem here.

@mvktsk
Copy link
Contributor

mvktsk commented Aug 25, 2023

Task https://virtocommerce.atlassian.net/browse/VP-8432 has been created

@Dan-BV
Copy link

Dan-BV commented Aug 28, 2023

Hi, @alynabriscoe!
Please send us the full platform manifest (with modules installed).
image

@alynabriscoe
Copy link
Author

vc-platform-info.zip
Here's both the manifest and package @Dan-BV

@Dan-BV
Copy link

Dan-BV commented Aug 29, 2023

@alynabriscoe
We thank you for your appeal. A bug has been added to the platform project on this issue. We will inform you about the change in its status.

@OlegoO
Copy link
Contributor

OlegoO commented Aug 30, 2023

@alynabriscoe @Dan-BV I think, it's correct behaviour. By default. if you update/delete the value in the dictionary for a given property, that change is not propagated to the items with that property value.

It's preventing from data corruption.

To achieve your requirement, I think we can implement options,that we did for catalog module:

  1. Update Metadata Only
  2. Apply on items

image

@alynabriscoe
Copy link
Author

@OlegoO that sounds like a good option to me! Would that work for both updating a value as well as deleting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants