Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Descale props #14

Closed
LightArrowsEXE opened this issue Sep 14, 2024 · 0 comments
Closed

Rename Descale props #14

LightArrowsEXE opened this issue Sep 14, 2024 · 0 comments

Comments

@LightArrowsEXE
Copy link
Collaborator

LightArrowsEXE commented Sep 14, 2024

For clarity purposes (and so I can support them in Jaded-Encoding-Thaumaturgy/vs-preview#182 without fear of it overlapping with other random props), it may be a good idea to prefix these props with "DT" or otherwise rename them to make it clear these are properties from your descaling classes.

self.descaled = self.descaled.std.SetFrameProp("Target", self.index)
self.rescaled = self.rescaled.std.SetFrameProp("Target", self.index)
self.upscaled = self.upscaled.std.SetFrameProp("Target", self.index)

self.input_clip = clip.std.SetFrameProp("Target", self.index + 1)

Note that the official Vapoursynth documentation recommends using CamelCase for frame properties.

@Vodes Vodes closed this as completed in d95ac9f Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant