Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements: Tests #42

Closed
wants to merge 5 commits into from
Closed

Improvements: Tests #42

wants to merge 5 commits into from

Conversation

JuiP
Copy link
Contributor

@JuiP JuiP commented Aug 4, 2021

#41 In Progress

@JuiP
Copy link
Contributor Author

JuiP commented Aug 4, 2021

I find one more thing very confusing... Didn't notice this before but the 'estimator' and 'Estimator' variables are very inconsistent. I guess I should make them consistent throughout the test files and the Helper functions?

@JuiP JuiP mentioned this pull request Aug 4, 2021
Merged
3 tasks
@ataymano
Copy link
Member

ataymano commented Jan 14, 2022 •
edited
Loading

Looks like all changes from here are already included in #43, so we can cancel this one?

@JuiP
Copy link
Contributor Author

JuiP commented Jan 17, 2022

@ataymano Originally, the plan was to keep work on items from the project board separate from improvements. But right now, yes it makes sense to close this PR.

@JuiP JuiP closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ataymano ataymano ataymano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuiP @ataymano