diff --git a/src/assets/wise5/classroomMonitor/classroomMonitorComponents/milestones/milestone-grading-view/milestone-grading-view.component.ts b/src/assets/wise5/classroomMonitor/classroomMonitorComponents/milestones/milestone-grading-view/milestone-grading-view.component.ts index 075bed3d065..dc03452ac74 100644 --- a/src/assets/wise5/classroomMonitor/classroomMonitorComponents/milestones/milestone-grading-view/milestone-grading-view.component.ts +++ b/src/assets/wise5/classroomMonitor/classroomMonitorComponents/milestones/milestone-grading-view/milestone-grading-view.component.ts @@ -147,8 +147,8 @@ export class MilestoneGradingViewComponent extends NodeGradingViewComponent { this.saveMilestoneWorkgroupItemViewedEvent(workgroupId, value); } - updateWorkgroup(workgroupId: number, init = false): void { - super.updateWorkgroup(workgroupId, init); + protected updateWorkgroup(workgroupId: number): void { + super.updateWorkgroup(workgroupId); const workgroup = this.workgroupsById[workgroupId]; workgroup.score = this.getScoreByWorkgroupId(workgroupId); if (this.milestone.report.locations.length > 1) { @@ -160,9 +160,7 @@ export class MilestoneGradingViewComponent extends NodeGradingViewComponent { ); workgroup.changeInScore = this.getChangeInScore(workgroup.initialScore, workgroup.score); } - if (!init) { - this.workgroupsById[workgroupId] = copy(workgroup); - } + this.workgroupsById[workgroupId] = copy(workgroup); } private getChangeInScore(initialScore: number, revisedScore: number): number { diff --git a/src/assets/wise5/classroomMonitor/classroomMonitorComponents/nodeGrading/node-grading-view/node-grading-view.component.ts b/src/assets/wise5/classroomMonitor/classroomMonitorComponents/nodeGrading/node-grading-view/node-grading-view.component.ts index 053c484c6b0..799f5648376 100644 --- a/src/assets/wise5/classroomMonitor/classroomMonitorComponents/nodeGrading/node-grading-view/node-grading-view.component.ts +++ b/src/assets/wise5/classroomMonitor/classroomMonitorComponents/nodeGrading/node-grading-view/node-grading-view.component.ts @@ -153,7 +153,7 @@ export class NodeGradingViewComponent implements OnInit { const workgroupId = workgroup.workgroupId; this.workgroupsById[workgroupId] = workgroup; this.workVisibilityById[workgroupId] = false; - this.updateWorkgroup(workgroupId, true); + this.updateWorkgroup(workgroupId); } } @@ -240,9 +240,8 @@ export class NodeGradingViewComponent implements OnInit { * Update statuses, scores, notifications, etc. for a workgroup object. Also check if we need to * hide student names because logged-in user does not have the right permissions * @param workgroupID a workgroup ID number - * @param init Boolean whether we're in controller initialization or not */ - protected updateWorkgroup(workgroupId: number, init = false): void { + protected updateWorkgroup(workgroupId: number): void { const workgroup = this.workgroupsById[workgroupId]; const alertNotifications = this.notificationService.getAlertNotifications({ nodeId: this.nodeId, diff --git a/src/messages.xlf b/src/messages.xlf index 7eec122f49b..e518013b512 100644 --- a/src/messages.xlf +++ b/src/messages.xlf @@ -13556,7 +13556,7 @@ Click "Cancel" to keep the invalid JSON open so you can fix it. src/assets/wise5/services/teacherDataService.ts - 604 + 575 @@ -13910,14 +13910,14 @@ Are you sure you want to proceed? Team has not saved any work src/assets/wise5/classroomMonitor/classroomMonitorComponents/workgroup-component-grading/workgroup-component-grading.component.html - 16,18 + 22,24 See revisions src/assets/wise5/classroomMonitor/classroomMonitorComponents/workgroup-component-grading/workgroup-component-grading.component.html - 26 + 32