build: upgrade all the things #67
Conversation
Robbert
force-pushed
the
build/updates
branch
2 times, most recently
from
26c6d6d to
e0289b5
Compare
Robbert
force-pushed
the
build/updates
branch
from
467c142 to
b559bec
Compare
|
Thanks Robbert! 🙏 I think there's something wrong with the linter/prettier, as running Also The rest of the changes look reasonable to me, but I'd love an extra pair of eyes on this. Maybe @Ryuno-Ki would like to do the honors? |
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| node-version-file: .nvmrc | ||
| - run: npm ci |
There was a problem hiding this comment.
This works.
If you want to disable the postinstall scripts, npm ci --ignore-scripts would be the option to set.
This might prevent malicious scripts from being executed.
|
|
||
| export default [ | ||
| { | ||
| languageOptions: { globals: globals.browser }, |
There was a problem hiding this comment.
I usually see this option at the last position (so it can override previous ones).
I guess giving this configuration it should work ™️ , though.
| import Fondue from "./src/fondue/Fondue.mjs"; | ||
|
|
||
| export async function fromPath(fontPath) { | ||
| const { readFile } = await import("node:fs/promises"); |
There was a problem hiding this comment.
Curious why this wasn't imported in line 16, but that shouldn't block the PR.
| "prettier": "^2.0.5", | ||
| "rollup": "^2.21.0" | ||
| }, | ||
| "jest": { |
There was a problem hiding this comment.
Where did this configuration move to?
(Now vitest is used over jest)
| "@rollup/plugin-json": "6.1.0", | ||
| "@rollup/plugin-node-resolve": "15.3.0", | ||
| "@vitest/coverage-v8": "2.1.3", | ||
| "babel-jest": "29.7.0", |
| "collectCoverageFrom": [ | ||
| "src/*.{js,jsx}" | ||
| ] | ||
| "@babel/preset-env": "7.25.8", |
There was a problem hiding this comment.
If babel-jest is dropped, can this be removed as well?
Oops, I accidentally already created a PR.
To do:
fix eslint no-useless-escape issuesremoves regexp escapes. However the existing ESLint config specifically disables this rule. Is there a reason the escapes are actually needed? In that case:no-useless-escapein the new eslint configfetchis now available in Node.js, and theshim-fetch.jsfromlib-fontis no longer being used. This causes all tests to fail, because local paths are treated differently. I'm not sure if this is a breaking change, or if thefromPathfunction is already broken in Node 22 in the current release.fromPathandfromDataBuffer.fromPathis uses in Node.js only, andfromDataBufferis used in the browser mainly. MakingfromPathNode.js only makes sense to me. For browser support I suggest adding a newfromURLAPI.