Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the linters #189

Open
RoelN opened this issue Oct 8, 2024 · 3 comments
Open

Fix the linters #189

RoelN opened this issue Oct 8, 2024 · 3 comments

Comments

@RoelN
Copy link
Contributor

RoelN commented Oct 8, 2024

Like @Ryuno-Ki said, it looks like there are two linters in place?

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Oct 8, 2024

That's prettier

"prettier": "^2.7.1",

and vue-cli-service lint:

"lint": "vue-cli-service lint"

I assume the latter is using eslint:

"eslint": "^8.23.1",

You have a .eslintrc.js:

https://github.com/Wakamai-Fondue/wakamai-fondue-site/blob/master/.eslintrc.js

so the Prettier dependency could be dropped (but eslint-plugin-prettier kept)

@RoelN
Copy link
Contributor Author

RoelN commented Oct 8, 2024

I didn't remove the dependency in #191 as I saw "@vue/eslint-config-prettier also being a dependency there. I wonder if it was added because one of the lint systems is using it?

Either way, local linting (via command line and in my editor) is now okay, with #191 merged. Do you suggest to remove it anyway, as it's "just" a dev dependency?

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Oct 8, 2024

Hm, I hope it should work. I was confused by Prettier being present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants