Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every single rom online fails the CRC check #45

Open
NIGELTEAPOT opened this issue Aug 13, 2024 · 2 comments
Open

Every single rom online fails the CRC check #45

NIGELTEAPOT opened this issue Aug 13, 2024 · 2 comments

Comments

@NIGELTEAPOT
Copy link

NIGELTEAPOT commented Aug 13, 2024

I have tried over a dozen roms of 1.0, 1.1, 1.2, and gamecube from different sites, and all fail the crc check here despite working in emulators and crc checkers.

After looking at the code, and realizing you are ONLY checking for PAL roms, the very first PAL region 1.0 rom I tried worked.

Please update to allow for NA roms.

1.0: cd16c529

1.1: 3fd2151e

1.2: 32120c23

Gamecube: 346de3ae

@Horonelius
Copy link

Horonelius commented Sep 2, 2024

Ship is designed around the PAL version, so thats why the check requires PAL roms. Ideally you would want to bring this up with the Shipwright devs.

@NIGELTEAPOT
Copy link
Author

NIGELTEAPOT commented Sep 2, 2024 via email

Repository owner deleted a comment from Sam2much96 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants