Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Werewolves #1414

Open
Cheaterpaul opened this issue Feb 19, 2024 · 1 comment
Open

Incompatibility with Werewolves #1414

Cheaterpaul opened this issue Feb 19, 2024 · 1 comment

Comments

@Cheaterpaul
Copy link

Cheaterpaul commented Feb 19, 2024

Minecraft Information (please complete all questions entirely):

  • Minecraft Version: 1.20.1
  • Forge Version: 47.1.0
  • MCA Version: 7.5.14
  • Vampirism: 1.10.6
  • Werewolves: 2.0.0.0-beta.2 (beta.3 will crash)

Describe the bug

There is a conflict between Werewolves and MCA Reborn targeting the player renderer.
Werewolves renders a werewolf model when the player transforms into a werewolf form.
We explored a few ways how this can be best implemented, but every time we encountered the issues that the MCA Reborn villager feature (mixin) completely denies rendering of other models for the player.

Reproduction

  1. become werewolf /vampirism level werewolves:werewolf 14
  2. open skill menu
  • press p (default keybinding)
  • select fang button
  1. unlock beast form skill or survivalist form skill
    image
  2. exit menus
  3. Select form with mouse and click (best to use at day time)
    image

Solution 1

I found the option to disable the villager feature TeamLapen/Werewolves#182, which will allow the werewolf model to be rendered again. It would be great if werewolves could be included in the default list

Solution 2 (not tested)

Only relevant if this mixin is intended to target only players.

Currently this will cancel all renderer regardless where they come from. An additional check for this instanceof PlayerEntityRenderer would ensure that only the default player rendering is disabled and not other renderer as well.

Remarks

the Werewolves 2.0.0.0-beta.3 was an attempt to extend PlayerRenderer in the werewolf player renderer, but is just causes more issues because MCA modifies the renderer to use PlayerEntityExtendedModels

@goldrichman9Modded
Copy link

Maybe also let MCA become werewolves if the mod is install to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants