Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

".tgz" files somtimes decompressed in error. #437

Open
jerrm opened this issue Nov 19, 2020 · 1 comment · May be fixed by #438
Open

".tgz" files somtimes decompressed in error. #437

jerrm opened this issue Nov 19, 2020 · 1 comment · May be fixed by #438

Comments

@jerrm
Copy link

jerrm commented Nov 19, 2020 •
edited
Loading

Requests.php will mistakenly decompress a .tgz file (or other gzipped files) downloaded from sites that pass a "content-encoding: none" header.

In the case of .tgz files, you end up with a misnamed, uncompressed tar file. Often manageable, but not if there needs to be an md5/sha1/etc checksum confirmation.

The decompress code is wrapped by if (isset($return->headers['content-encoding'])), so the decompress code fires even though the encoding is "none". Should there be a check for a proper encoding type, or at minimum, check for "none" before decompressing?

Ran into this with bitbucket. A sample file to demonstrate the issue: https://bitbucket.org/jerrm-bb/testdownload/downloads/outcnam-test.tgz
@jerrm
Copy link
Author

jerrm commented Nov 22, 2020 •
edited
Loading

For further clarification and provide workarounds for anyone that lands here from google:

The problem occurs when accessing $response->body.

The below code will errantly decompress the .tgz file:

$response = Requests::get('https://bitbucket.org/jerrm-bb/testdownload/downloads/outcnam-test.tgz', array(), array());
file_put_contents('response-body-test', $response->body);

Easiest work-around I've found is to save the file using $options and avoid accessing $response->body:

Requests::get('https://bitbucket.org/jerrm-bb/testdownload/downloads/outcnam-test.tgz', array(), array('filename' => 'options-save-test'));

If the intact body is needed for further processing, extract it from $response->raw:

$response = Requests::get('https://bitbucket.org/jerrm-bb/testdownload/downloads/outcnam-test.tgz', array(), array());
$pos = strpos($response->raw, "\r\n\r\n");
$filedata = substr($response->raw, $pos + strlen("\n\r\n\r"));
file_put_contents('extracted-filedata-test', $filedata);

@jerrm jerrm linked a pull request Nov 22, 2020 that will close this issue
Open
@jrfnl jrfnl mentioned this issue Nov 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only decompress with proper content-encoding header jerrm/Requests
1 participant
@jerrm