Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Available Hook in Doc and Missing Hook Parameter #220

Open
mamist2790 opened this issue Jun 20, 2016 · 1 comment · May be fixed by #679
Open

Missing Available Hook in Doc and Missing Hook Parameter #220

mamist2790 opened this issue Jun 20, 2016 · 1 comment · May be fixed by #679

Comments

@mamist2790
Copy link

There is a hook, 'curl.after_send', located in Requests/Transport/cURL.php on line 165 that is not listed in the Hooks section of the documentation. Also, the parameters array is empty and I believe it should include &$this->handle.

For example in my case I need to have access to the request headers in case of an error so I can log them. I set CURLINFO_HEADER_OUT using curl_setopt in my curl.before_send hook. In order to actually access that header though I still need access to the handle when using the curl.after_send hook.

@jrfnl jrfnl added this to the 2.x Next milestone Nov 25, 2021
@jrfnl jrfnl modified the milestones: 2.0.1, 2.1.0 Feb 7, 2022
@jrfnl jrfnl linked a pull request Feb 7, 2022 that will close this issue
@jrfnl jrfnl removed this from the 2.1.0 milestone Feb 28, 2022
@jrfnl
Copy link
Member

jrfnl commented Feb 28, 2022

Before we actually action this, we should have a good look at the security implications of allowing access to the $handle (not just here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants