Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version check on webOS - read from /var/run/nyx/os_info.json? #149

Open
csdougliss opened this issue Mar 2, 2023 · 3 comments
Open

Comments

@csdougliss
Copy link

webOS does not return valid information when running lsb_release -a:

LSB Version:	n/a
Distributor ID:	n/a
Description:	(none)
Release:	n/a
Codename:	n/a

uname -a returns:

Linux LGwebOSTV 5.4.96-266.mlt4tv.1 #1 SMP PREEMPT Fri Nov 25 04:25:18 UTC 2022 aarch64 GNU/Linux

The OS information is contained in:

/var/run/nyx/os_info.json

Contents of /var/run/nyx/os_info.json:

{
    "core_os_kernel_version": "5.4.96-266.mlt4tv.1",
    "core_os_name": "Rockhopper",
    "core_os_release": "7.2.0-47",
    "core_os_release_codename": "mullet-marine",
    "encryption_key_type": "prodkey",
    "webos_build_datetime": "20221207040929",
    "webos_build_id": "47",
    "webos_imagename": "lib32-starfish-global-secured",
    "webos_manufacturing_version": "03.21.45",
    "webos_name": "webOS TV",
    "webos_prerelease": "",
    "webos_release": "7.2.0",
    "webos_release_codename": "mullet-marine",
    "webos_release_platformcode": "7"
}

Can this module be modified to support webOS by checking for LGwebOSTV in uname and then read the information in /var/run/nyx/os_info.json?

@enen92
Copy link
Contributor

enen92 commented Mar 2, 2023

Sure, this can be implemented.
But that only make sense after webos support is in. For now it'd be great that at least it doesn't crash (see the other issue)

@csdougliss
Copy link
Author

csdougliss commented Apr 7, 2023

@enen92 webos support (wayland, hardware video decoding) is now merged into master 👍 Is this issue something that could now be looked at for implementation?

@anxdpanic
Copy link
Member

There will be a webos check in the next version, untested as I don't have a device. I didn't add upgrading because I am currently unaware of how that is done on webos. But notifications should work if they weren't before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants