Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to collapse any file session with <details> tag #124

Open
quizzical-spade opened this issue Jun 26, 2024 · 3 comments
Open

Add ability to collapse any file session with <details> tag #124

quizzical-spade opened this issue Jun 26, 2024 · 3 comments

Comments

@quizzical-spade
Copy link

Currently, if you want to ignore a file, you just have to scroll past it and hope you don't scroll too far and miss something. Adding collapse tags would be really nice!

Short Eg:

Networking

server.properties

network-compression-threshold

Good starting value: 256

This allows you to set the cap for the size of a packet before the server attempts to compress it. Setting it higher can save some CPU resources at the cost of bandwidth, and setting it to -1 disables it. Setting this higher may also hurt clients with slower network connections. If your server is in a network with a proxy or on the same machine (with less than 2 ms ping), disabling this (-1) will be beneficial, since internal network speeds can usually handle the additional uncompressed traffic.

purpur.yml

use-alternate-keepalive

Good starting value: true

You can enable Purpur's alternate keepalive system so players with bad connection don't get timed out as often. Has known incompatibility with TCPShield.

Enabling this sends a keepalive packet once per second to a player, and only kicks for timeout if none of them were responded to in 30 seconds. Responding to any of them in any order will keep the player connected. AKA, it won't kick your players because 1 packet gets dropped somewhere along the lines
~ https://purpurmc.org/docs/Configuration/#use-alternate-keepalive

This way people running Purpur can disable Pufferfish.yml sections so they don't search for a file that doesn't exist (me, because I'm not very smart).

@YouHaveTrouble
Copy link
Owner

Problem with this approach is - details are hidden by default.
This would make people miss entire sections

@quizzical-spade
Copy link
Author

I'd argue that the type of person to sit and tune their MC server by hand is the type of person to expand all the sections anyway; especially if they see that the guide starts off completely collapsed.

@YouHaveTrouble
Copy link
Owner

Well, actually

there's an `open` tag for details tag that opens it on default. If someone opened a PR and made sure it works properly with # links I would have merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants