Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RotationOption::SizeMB takes integer argument and may not be fine grained enough #3

Open
Zylatis opened this issue Dec 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Zylatis
Copy link
Owner

Zylatis commented Dec 24, 2021

I imagine most people don't need to rotate their logs under 1mb in size but potentially certain environments require that, it makes testing easier, and there's no good reason why we shouldn't support it. The question is, do we change the argument of the enum to float or make a separate SizeBytes enum option?

@Zylatis Zylatis added the enhancement New feature or request label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant