Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSoC 2024 VulnTotal Browser Extension Project Report #146

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

michaelehab
Copy link
Contributor

@michaelehab michaelehab commented Aug 29, 2024

Tasks

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelehab looks great, specially the challenges part. Thanks!

  1. Can you add a section like this: https://aboutcode--146.org.readthedocs.build/en/146/archive/gsoc/reports/2024/scancodeio_scorecode_pranay.html#project-reference-links
  2. Can you fix the documentation tests, these are minor cosmetic adjustments
  3. Let's also add links to the actual extensions (like the chrome store which can be added later, maybe something similar for firefox?)

@michaelehab michaelehab force-pushed the gsoc2024-report branch 2 times, most recently from 590bef3 to 6133e20 Compare August 30, 2024 17:48
@michaelehab
Copy link
Contributor Author

Hello @AyanSinhaMahapatra
Thanks for the review!
I added the official GSoC page, I already had the links to the proposal and the github repo.
I also fixed the tests, please check them again.
For the extension links, I guess we can add them later when the extension becomes available on a store, or if we can finish this soon I can add it as a part of this PR.

Signed-off-by: Michael Ehab <[email protected]>
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelehab , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit fe4c845 into aboutcode-org:main Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants