Fix Entity Hydration Issue for Inherited Entities with DiscriminatorMap #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @james2001 thank you for this PR, it looks very interesting. I'll try review it soon. |
|
@npotier Any news on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
In the existing system, the hydration of entities resulting from a search query is not geared towards entity hierarchies that have a DiscriminatorMap. This leads to a "ResultSetMapping builder does not currently support your inheritance scheme" error when attempting to use ResultSetMappingBuilder with entities that have an inheritance hierarchy.
Proposed Solution
Instead of relying on a native SQL query and ResultSetMappingBuilder, this PR employs DQL to fetch the entities, which natively supports DiscriminatorMap. After fetching the entities using DQL, we use usort in PHP to sort them in the desired order. This allows us to circumvent the aforementioned error while retaining the ability to sort the entities.
This also likely fixes Issue #87 as we no longer use the FIELD function in our queries.