Decrease docker image size by 200MB #3540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with our self-hosted runners, so far so good. |
duboisf
force-pushed
the
fix/docker-size
branch
from
34aade2
to
b5af93d
Compare
Copying and then deleting the docker directory in 2 steps (therefore, layers) means the docker directory is still present in the previous layer. We uncompress the docker.tgz in the /tmp directory to be able to copy the docker binaries directly to their target destination.
duboisf
force-pushed
the
fix/docker-size
branch
from
b5af93d
to
4e042a3
Compare
|
@TingluoHuang what is the process for getting this reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
200MB saved for each image pull times probably a bazillion pulls == lots of bandwidth saved? 😁
The dockerfile was originally copying and then deleting the docker directory in 2 steps. This creates a "whiteout" that hides the docker directory in the previous layer. Alas, the original docker folder is still present (and takes up space, 200MB to be precise) in the previous layer.
To fix this, we uncompress the docker.tgz in the /tmp directory to be able to copy the docker binaries directly to their target destination.
dive differences: