Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable path overlap validation flag #1

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add disable path overlap validation flag #1

merged 2 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. Add disable path overlap validation flag 

      ## What this PR does / why we need it:

In kubernetes#5651 there was a
request to throw an error when there are two ingresses defining the same
host and path, which was implemented as part of the validation webhook.

  Despite of this there are clear rules on the ingress controller that
describes what the controller would do in [such situation (the oldest
rule wins)](https://github.com/kubernetes/ingress-nginx/blob/main/docs/how-it-works.md?plain=1#L27)

  Some users are relying on this validation behaviour to prevent
misconfigurations, but there are use cases where allowing it, maybe
temporarily, is helpful.

Change-Id: I9d4124d1c36876b06d63100cd10988eaf2f41db9
    @Fsero
    Fsero committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e8a10e1 View commit details
    Browse the repository at this point in the history

  2. fixup! Add disable path overlap validation flag

    @Fsero
    Fsero committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    25f60cb View commit details
    Browse the repository at this point in the history