Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Updated radio button demos #1103

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[Demo] Updated radio button demos #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20d562a
[Demo] Updated radio button demos (removing title & description, now …
LouisBorleeAdevinta Oct 30, 2024
6029412
Merge branch 'main' into demo-fix-radio-button
LouisBorleeAdevinta Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .Demo/Classes/View/Components/RadioButton/SwiftUI/RadioButtonComponent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ struct RadioButtonComponent: View {
labelAlignment: self.trailingLabel == .selected ? .trailing : .leading,
groupLayout: self.verticalLayout == .selected ? .vertical : .horizontal
)
.title("Radio Button Group (SwiftUI)")
.supplementaryText("Radio Button Group Supplementary Text")
.disabled(self.isDisabled == .selected)
}
)
Expand Down
7 changes: 1 addition & 6 deletions .Demo/Classes/View/Components/RadioButton/UIKit/RadioButtonComponentUIView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,14 @@ final class RadioButtonComponentUIView: ComponentUIView {

// MARK: - Private construction helper
static private func makeRadioButtonView(_ viewModel: RadioButtonComponentUIViewModel) -> RadioButtonUIGroupView<Int> {

let component = RadioButtonUIGroupView(
return .init(
theme: viewModel.theme,
intent: viewModel.intent,
selectedID: viewModel.selectedRadioButton,
items: viewModel.content,
labelAlignment: viewModel.labelAlignment,
groupLayout: viewModel.axis
)

component.title = "Radio Button Group (UIKit)"
component.supplementaryText = "Radio Button Group Supplementary Text"
return component
}

static private func makeSingleRadioButtonView(_ viewModel: RadioButtonComponentUIViewModel) -> RadioButtonUIView<Int> {
Expand Down
Loading