Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not quite correct semantic structure in the Hero section, missing <h1> #1

Open
getFrontend opened this issue Mar 16, 2024 · 1 comment

Comments

@getFrontend
Copy link

For correct semantic structure when using the <section> tag, we must use at least one H1 or H2 header.

It would be more correct not to set a paragraph: <p id="hero" className="hero-title">iPhone 15 Pro</p>, but to make it a first-level heading: <h1 id="hero" className="hero-title">iPhone 15 Pro</h1>.

@getFrontend
Copy link
Author

Also "Get the highlights." should be H2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant