Getting viewModel inside BoxWithConstraints

[IlyaChizhanov]

On Voyager screen with ViewModel, if we get viewModel inside BoxWithConstraints, then viewModel will be get twice.

Here's a demo project with the issue:

val koinModule = module {
    viewModelOf(::ScreenAViewModel)
    viewModelOf(::SubScreenViewModel)
}

class ScreenAViewModel(val id: Int) : ViewModel() {
    init {
        Timber.d("init $id")
    }

    override fun onCleared() {
        Timber.d("onCleared $id")
        super.onCleared()
    }
}

class SubScreenViewModel(val id: Int) : ViewModel() {
    init {
        Timber.d("init $id")
    }

    override fun onCleared() {
        Timber.d("onCleared $id")
        super.onCleared()
    }
}

data class ScreenA(val id: Int) : Screen {

    override val key: ScreenKey = uniqueScreenKey

    @Composable
    override fun Content() {
        val navigator = LocalNavigator.currentOrThrow
        val viewModel: ScreenAViewModel = koinViewModel { parametersOf(id) }

        Column(
            Modifier.fillMaxSize(),
            verticalArrangement = Arrangement.Center,
            horizontalAlignment = Alignment.CenterHorizontally
        ) {
            Box(
                Modifier
                    .size(200.dp)
                    .background(Color.Red)
                    .clickable {
                        Timber.d("Red clicked")
                        navigator.push(ScreenA(id + 1))
                    }
            ) {
                Text("id: ${viewModel.id}")
            }
            BoxWithConstraints {
                SubScreen(id)
            }
        }
    }
}

@Composable
fun SubScreen(id: Int) {
    val navigator = LocalNavigator.currentOrThrow
    val viewModel: SubScreenViewModel = koinViewModel(key = id.toString()) { parametersOf(id) }

    Box(
        Modifier
            .size(200.dp)
            .background(Color.Blue)
            .clickable {
                Timber.d("Blue clicked")
                navigator.pop()
            }
    ) {
        Text("id: ${viewModel.id}")
    }
}

This is what the log outputs:

This is completely unexpected behavior.
I encountered this in my project inside a complex UI tree and it was not easy to understand what was happening.