Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/remove InstancedEntity API #13

Open
tobiascornille opened this issue Oct 15, 2024 · 2 comments · May be fixed by #14
Open

Create/remove InstancedEntity API #13

tobiascornille opened this issue Oct 15, 2024 · 2 comments · May be fixed by #14
Labels
enhancement New feature or request

Comments

@tobiascornille
Copy link

I'm converting part of an existing app to use instancing. In different parts of the codebase, the same object is created, so I'd like to replace those with instances. I figured out I can create InstancedEntities myself and use a shared InstancedMesh2. However, I still have to manage the current instance index when adding instances,and I still have to swap instances when removing an instance.

Would you be open for an API addition on InstancedMesh2 that'd allow users to add and remove InstancedEntities explicitly? If so, I could prepare a PR.

@agargaro
Copy link
Owner

I have actually already started working on this.

I would like to be able to handle the array of instances in the same way that arrays are handled in javascript.

If you'd like we can write to each other on discord (there is the server linked in the README), so you can help me implement and decide the API if you want 😄

@tobiascornille
Copy link
Author

Awesome, will join indeed ❤️

@tobiascornille tobiascornille linked a pull request Oct 17, 2024 that will close this issue
@tobiascornille tobiascornille changed the title Add/remove InstancedEntity API Create/remove InstancedEntity API Oct 17, 2024
@agargaro agargaro added the enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants