Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to accept optimize React.memo() #1148

Open
1 task
ahmedx33 opened this issue Oct 22, 2024 · 2 comments
Open
1 task

Failed to accept optimize React.memo() #1148

ahmedx33 opened this issue Oct 22, 2024 · 2 comments

Comments

@ahmedx33
Copy link

ahmedx33 commented Oct 22, 2024

What version of million are you using?

latest version of Million.js

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Windows

What browser are you using?

Chrome - Edge

Describe the Bug

when i try to accept any optimization with React.memo it throws this error

Failed to accept Optimize 2 re-renders: React.memo SearchableSelect
not only in this component , it throws with any component needs optimization using React.memo()
it shows me the changes but it doesn't apply them

here is some images:

  • old component

image

  • new changes

image

  • the error

image

What's the expected result?

it should accept the changes and apply them on the component

Link to Minimal Reproducible Example

.

Participation

  • I am willing to submit a pull request for this issue.
Copy link

Thanks for opening this issue! A maintainer will review it soon.

@aidenybai
Copy link
Owner

@ahmedx33 sorry about the delay! Are you able to reproduce this issue on the latest version? We recently pushed a patch npx million@latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants