-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged fonts not working #7
Comments
Hello, ok thanks, i will test. can you give your font file for a test case ? what are the resolution of the two fonts you use ? the best case is to have two font with exactly same ascent/descent and baseline for the moment. for the moment the quick thing you can do is to use the old way :
|
Fonts and .ifs file is attached below.
They should be same because I draw some of them . If they are not then I made a mistake when drawing.
Sorry, I have no idea about that. I use icomoon.io to prepare icons/fonts
I will, thank you. |
i have maybe another explain. there is two type of font glyphs. ImGuiFontStudio can export for the moment only simple Glyph. Edit : i have tested and indeed its a bug. many glyphs seems not exported. and they are all simple glyphs. i will check that tonight :) |
… bad font format. not in all case (not seen with my fonts), but can so just added an option for disable it in generator settings, if the user ensure than he not want glyph rescale just a little help, the time to analyse what is wrong. can take some time
had some issue on last fix for macos/linux. but its fixed now. so you can pull |
Can be important for check if Font Format is bad or not. regarding lat issue #7 on merged font generation. very difficult to see here is the error
Sorry for late response. This works great, thank you :) |
it seems your two fonts have issue. in fontforge when you go in menu : element / validation (for french menu) he found many errors on many glyphs ,and seem to be the glyphs we not see after merge. So the question is : how can we avoid issue with bad glyph format :) |
Yeah, it is my bad :) Sorry about that. I don't know much about glyph. I have Fontforge installed but looks too complex to me. So I did use the icomoon.io for generating fonts from my svg files. I draw those svg's at Illustrator by using Material Icons guideline. But it is highly possible that I did some mistakes when drawing. Also it is possible that icomoon.io is failling at some point and cause this problem. I will definitely check out the Fontforge properly. Thank you. |
np, its interesting, all the softwares can avoid the issue and generate good font. and its in my plan to have the possibilite to draw glyph and merge svg, so at a moment i need to be robust for this generation :) |
i found, the cmap table who is responsible of glyph mapping, is badly generated. |
This was really helpful, thank you. I clean all errors by using Fontforge. |
so, after glyph correction in font forge, the merge in ImGuiFontStudio was ok ? this is that ? |
Yes it is. It is ok in ImGuiFontStudio. Problems was about my faults(drawing directions and wrong compound paths may cause fail). |
ok good to hear. i will try to detect and correct bad path so. |
I did merge two different font files. Fonts from second file(tasks.ttf) is not working from generated as header+cpp. Files are attached below.
Header + CPP files: Archive.zip
The text was updated successfully, but these errors were encountered: