Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: transport should do branching ahead of the hot path #9

Open
aljazerzen opened this issue Feb 22, 2024 · 0 comments
Open

perf: transport should do branching ahead of the hot path #9

aljazerzen opened this issue Feb 22, 2024 · 0 comments

Comments

@aljazerzen
Copy link
Owner

When moving values from a producer to a consumer, we utilize crate::utils::transport::transport function.

It contains branching depending on the type of the field that is being transported.
In most of the cases, we iterate over an array (or multiple arrays), which means that fields repeat a lot.

It would (probably) be much more performant to have a transporter function instead, that would be specialized for a specific type. These functions would be created prior to iteration over the arrays.

In the case of converting rows into RecordBatch, we could have these functions in an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant