Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate simplifying createAll requirements for components receiving configuration #5369

Closed
2 tasks
Tracked by #5292
romaricpascal opened this issue Sep 30, 2024 · 0 comments · Fixed by #5374
Closed
2 tasks
Tracked by #5292

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Sep 30, 2024

What

Investigate if we can have a simpler requirement for createAll to pass them a configuration during initialisation, especially not mandating for the component to have a static defaults property.

A possible route could be to just check the number of arguments of the component's constructor with length 🤔

Why

createAll will only pass a configuration to a component if it has a defaults static property storing a default configuration. While this helps with typing, this is quite a strong constraint on people that would want to implement their own components for use with createAll.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've investigated options for simplifying the implementation of configurable components usable with createAll
  • We've implemented any option we found suitable (if any).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready to release 🚀
Development

Successfully merging a pull request may close this issue.

1 participant