Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bindings] root.quit overrides help_menu.quit #252

Open
loralb opened this issue Sep 20, 2024 · 2 comments
Open

[bindings] root.quit overrides help_menu.quit #252

loralb opened this issue Sep 20, 2024 · 2 comments

Comments

@loralb
Copy link

loralb commented Sep 20, 2024

Hello! Thank you very much for your work!

The title pretty much says it all, the value set in help_menu.quit is ignored (both the default one and a custom one), because it is overriden by whatever the value in root.quit is (both if changing this binding to a custom one and if leaving the default value).

EDIT:
gitu --version -> gitu 0.25.0
System: Archlinux

@altsem
Copy link
Owner

altsem commented Sep 24, 2024

@loralb do you have a use-case to bind help_menu.quit and root.quit to different keys?
I'm considering doing something about the duplication of these in #257

@loralb
Copy link
Author

loralb commented Sep 24, 2024

I really like navigating through the various modes/menus/pop-ups by simply typing q or esc, but more than once I accidently closed the application by typing it one too many times. Basically, my use case is to use the defualt bindings for everything excpet for exiting gitu, for which I prefer something "more complex" (for example, I set it to ctrl+q for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants