feat: ctrl-c to quit the app #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now ctrl-c will exit the app, bypassing any bindings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 88.40% 88.41% +0.01%
==========================================
Files 62 62
Lines 5578 5583 +5
==========================================
+ Hits 4931 4936 +5
Misses 647 647 ☔ View full report in Codecov by Sentry. |
|
Hi! This is great :) I wonder if someone would ever want this to be configurable. 🤔 Perhaps it wouldn't hurt, what do you think? In the case, I believe there's a module "config.rs", as well as a "default_config.toml", where other stuff is configured. Currently on vacation so could include it in a release when I'm back home (February). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #258.
Firstly, thanks for this - I love magit and command line, so this feels like a perfect tool for me. As a thank you, I figured I will contribute a small ticket for you.
Now
ctrl-cwill exit the app bypassing any default or custom bindings. If you want to tweak the logic (for example exit only when the amount of screens is 1 i.e. root-level) - add more conditions tois_system_quitfunction.