Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--version doesn't show the version #279

Open
TLINDEN opened this issue Nov 4, 2024 · 4 comments
Open

--version doesn't show the version #279

TLINDEN opened this issue Nov 4, 2024 · 4 comments

Comments

@TLINDEN
Copy link

TLINDEN commented Nov 4, 2024

This is just a minor annoyance :)

% gitu --version
gitu 32fde9c

While this is pretty good from a developer perspective, a user who wants to check if there's an update, needs to check git commits. I'd suggest something like this:

% gitu --version
gitu v0.26.0 (32fde9c)
@altsem
Copy link
Owner

altsem commented Nov 4, 2024

That's peculiar, It's supposed to print either a version:

gitu on  master ❯ gitu --version
gitu v0.26.0

or if built from master, it should try describe the version

gitu on  master ❯ gitu --version
gitu v0.26.0-4-g93c3857

Where did you install it from?

@altsem altsem closed this as completed Nov 4, 2024
@altsem altsem reopened this Nov 4, 2024
@TLINDEN
Copy link
Author

TLINDEN commented Nov 5, 2024

Where did you install it from?

I installed a pre-compiled binary from the releases page.

@altsem
Copy link
Owner

altsem commented Nov 5, 2024

Damn

Thought I had fixed it and released a v0.27.0
Turns out it fails to describe latest tag when running CI...

./gitu --version
gitu v0.26.0-8-g8300bd6

🤦

This was after adding:

fetch-depth: 0 # Workaround to have a version set (gitu --version)
fetch-tags: true

@gkedge
Copy link

gkedge commented Dec 27, 2024

After downloading commit 8300bd60, clearly release 0.27.0, I got something different on ubuntu 22.04 than experienced by @TLINDEN :

$ gitu --version
gitu v0.26.0-8-g8300bd6

... got a version number, but it looks like to wasn't incremented. So, it looks fine to me with a reasonable oversight on the numbering,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants