Coding standards: Use 1 space after/before $ command

[klausi]

Problem: For me it is harder to read when a shell command starts immediately after the $ sign. Example:

$export DEBIAN_FRONTEND=noninteractive$?
$apt update$?
$yes '' | apt \
  -o Dpkg::Options::=--force-confold \
  -o Dpkg::Options::=--force-confdef \
  -y --allow-downgrades --allow-remove-essential \
  --allow-change-held-packages \
  upgrade$?
$apt autoremove -y$?
$snap refresh --color=never --unicode=never$?

This reads dense for me visually.

Proposed solution: use a coding standard of 1 space after/before the $ sign. Example:

$ export DEBIAN_FRONTEND=noninteractive $?
$ apt update $?
$ yes '' | apt \
  -o Dpkg::Options::=--force-confold \
  -o Dpkg::Options::=--force-confdef \
  -y --allow-downgrades --allow-remove-essential \
  --allow-change-held-packages \
  upgrade $?
$ apt autoremove -y $?
$ snap refresh --color=never --unicode=never $?

Much better, I can see the actual commands better!

What do you think?

[Ph0enixKM]

We could add such linting option or produce warnings if command is not padded with spaces from left and right. What do you think everyone?

[klausi]

Yep, for phase 1 we could update all the docs and existing scripts if people like this style. For phase 2 we could add the linting warning as you wrote.