🏗 Update Preact and TypeScript dependencies #39252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e `preact/dom` namespace to match changes in upstream
|
Hey @estherkim! These files were changed: Hey @ampproject/wg-performance! These files were changed: |
erwinmombay
reviewed
Jul 13, 2023
erwinmombay
reviewed
Jul 13, 2023
…eplace it with type casting
danielrozenberg
force-pushed
the
preact-ts-change
branch
from
229c71a to
5a10c15
Compare
erwinmombay
approved these changes
Jul 13, 2023
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
* Bump Preact to v10.16.0 * Change how Preact's `render`/`hydrate` functions are re-export via the `preact/dom` namespace to match changes in upstream * Bump Typescript to v4.9.5 * Fix typing issues * Revert change in build-system/tasks/build-story-localization.js and replace it with type casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Preact to v10.16.0 (which Renovate attempted to do in #37042) and TypeScript to v4.9.5 (which Renovated attempted to do in (#36642)
These two changes are co-dependent, and cause a lot of typing issues, which I fix in this PR.
For the most part these changes are trivial, but please review the change in
src/core/dom/index.jsthat might be more serious