Update ci.yml #1045
Update ci.yml #1045
Conversation
There was a problem hiding this comment.
Nice, but we should probably pick one tool and not run two, as they may end up fighting each other. Also, possibly ruff should be under consideration too?
.github/workflows/lint.yml
Outdated
|
|
||
| - name: Run linters | ||
| uses: wearerequired/lint-action@v2 | ||
| with: | ||
| black: true | ||
| flake8: true |
There was a problem hiding this comment.
Should we only call black then, and not flake8?
There was a problem hiding this comment.
This is just for checking, not fixing. So I don't mind running both. For fixing syntax we should make a choice.
- disable flake8 - enable black - enable (black_)auto_fix ONLY for pull requests, not for pushing to main directly
yes we should decide which tool(s) we would want. black and flake8 don't do exactly the same thing, so for checks we may want to use both. Or ruff, I'll have a look at that too. |
|
@LourensVeen I'm not sure how to test the auto-fix part of this, do you have any ideas for that? |
|
I've tested it on a different repository now. The linter will push a fix to the branch in the PR, which seems fine to me. |
|
I'm just not sure yet if this will fix only the files affected by the PR (which should be how this works) or if it checks all other files too (which I really really don't want). Need to be sure of that before merging. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
rieder
added
keep-open
and removed
stale
No description provided.