race

[Vany]

i start reading from .IncomingEvents

Write at 0x00c0003166a0 by goroutine 90:
  runtime.recvDirect()
      /Users/vany/sdk/go1.23.2/src/runtime/chan.go:388 +0x7c
  github.com/andreykaipov/goobs.(*Client).handleRawServerMessages.(*Client).markDisconnected.func1()
      /Users/vany/go/pkg/mod/github.com/andreykaipov/[email protected]/client.go:142 +0xcc
  sync.(*Once).doSlow()
      /Users/vany/sdk/go1.23.2/src/sync/once.go:76 +0xac
  sync.(*Once).Do()
      /Users/vany/sdk/go1.23.2/src/sync/once.go:67 +0x40
  github.com/andreykaipov/goobs.(*Client).markDisconnected()
      /Users/vany/go/pkg/mod/github.com/andreykaipov/[email protected]/client.go:135 +0x6d4
  github.com/andreykaipov/goobs.(*Client).handleRawServerMessages()
      /Users/vany/go/pkg/mod/github.com/andreykaipov/[email protected]/client.go:253 +0x6a0
  github.com/andreykaipov/goobs.(*Client).connect.gowrap1()
      /Users/vany/go/pkg/mod/github.com/andreykaipov/[email protected]/client.go:212 +0x40

Previous read at 0x00c0003166a0 by goroutine 91:
  runtime.chansend1()
      /Users/vany/sdk/go1.23.2/src/runtime/chan.go:157 +0x2c
  github.com/andreykaipov/goobs.(*Client).writeEvent()
      /Users/vany/go/pkg/mod/github.com/andreykaipov/[email protected]/client.go:378 +0x748
  github.com/andreykaipov/goobs.(*Client).handleOpcodes()
      /Users/vany/go/pkg/mod/github.com/andreykaipov/[email protected]/client.go:351 +0x6c0
  github.com/andreykaipov/goobs.(*Client).connect.gowrap2()
      /Users/vany/go/pkg/mod/github.com/andreykaipov/[email protected]/client.go:213 +0x40

[xaionaro]

Hey! These problems are supposed to be fixed here: #179 (you can try to use the temporary repo with the fixes: https://github.com/xaionaro-go/goobs; it will be deleted if the fixed will be merged)

[andreykaipov]

I feel like with how many concurrency issues crop up despite several attempts of PRs in the past to remediate those issues, it's really tempting to just pass on the burden of handling concurrency to client applications like gorilla/websocket has done.

I've never used this library extensively enough to bump into concurrency issues so I don't have a strong understanding of what's going on here, and without being able to reproduce it - it's difficult to provide a resolution unfortunately.

Let me know if @xaionaro's fix helps. I've also merged in another of their PRs #180, but the stracktraces look different enough that I don't think it will help.

[andreykaipov]

I cut a new release with @xaionaro's latest fixes https://github.com/andreykaipov/goobs/releases/tag/v1.5.2. I hope it can help.