Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify AudioAttributes for all playback scenarios #41

Open
dturner opened this issue Oct 18, 2019 · 1 comment
Open

Specify AudioAttributes for all playback scenarios #41

dturner opened this issue Oct 18, 2019 · 1 comment
Assignees

Comments

@dturner
Copy link
Contributor

dturner commented Oct 18, 2019

From Andrew:

With audio focus handling, it's now possible for the player to have playWhenReady true and player state READY, but not actually to be playing: https://github.com/google/ExoPlayer/blob/r2.10.5/library/core/src/main/java/com/google/android/exoplayer2/Player.java#L623

I think it's okay to leave this as it is because audio focus handling isn't enabled in this tutorial, but on the other hand the new method is quite easy to use so I wonder if we should be directing people to that. (Side note: I think it's also good practice to specify AudioAttributes for all playbacks, but the tutorial doesn't do that at the moment; if it did, then we'd also need to pass a boolean setting whether to enable/disable audio focus handling as ExoPlayer has a combined setter for both.)

@dturner dturner self-assigned this Oct 18, 2019
@dturner
Copy link
Contributor Author

dturner commented Jul 14, 2020

Need to use ExoPlayer's AudioAttributes class rather than the media API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant